Paket Lock Diff Report

This report was generated via Paket Lock Diff

Additions - (0)

Removals - (0)

Version Upgrades - (13)

• Main - (13)
  • Patch - (1)
    • Ionide.LanguageServerProtocol - 0.4.19 -> 0.4.20
  • Minor - (7)
    • MessagePack - 2.4.35 -> 2.5.108
    • MessagePack.Annotations - 2.4.35 -> 2.5.108
    • Microsoft.VisualStudio.Threading - 17.3.44 -> 17.6.40
    • Microsoft.VisualStudio.Threading.Analyzers - 17.3.44 -> 17.6.40
    • Microsoft.VisualStudio.Validation - 17.0.64 -> 17.6.11
    • Nerdbank.Streams - 2.8.61 -> 2.10.66
    • StreamJsonRpc - 2.12.27 -> 2.16.36
  • Major - (5)
    • Microsoft.Bcl.AsyncInterfaces - 6.0.0 -> 7.0.0
    • System.IO.Pipelines - 6.0.3 -> 7.0.0
    • System.Text.Encodings.Web - 6.0.0 -> 7.0.0
    • System.Text.Json - 6.0.5 -> 7.0.3
    • System.Threading.Tasks.Dataflow - 6.0.0 -> 7.0.0

Version Downgrades - (0)

Is this tracing strategy still required? if not I think we could fallback to the createRpc call that Ionide.LanguageServerProtocol provides compeltely?

And even if we do need to make customizations to the RPC, we could wrap the defaultRpc from Ionide.LSP like this instead or something:

Ionide.LanguageServerProtocol.Server.defaultRpc
>> (fun rpc -> 
  rpc.ActivityTracingStrategy <- ActivityTracingStrategy(Tracing.fsacActivitySource)
)

to make it super clear what behaviors we were modifying (and also reduce code duplication for the serialization fixes you just comitted).

The main issue comes down to we still have to override IsFatalException. F# doesn't support object expression after an object is already created. Maybe there's syntax to do it but I can't seem to make it happen. (something something composition over inheritence)

We could move all those logic to the LSP project. The tradeoff here is if we discover an exception we want to handle, we always to make changes elsewhere and may not actually be applicable to all LSP consumers.

Ugh, that's gross indeed. Thanks for taking the time to dig into it.